Re: A qsort template

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <rhaas(at)postgresql(dot)org>
Subject: Re: A qsort template
Date: 2022-04-12 00:40:45
Message-ID: CAApHDvrxefqXu4df8ZvkTHKvHNiWYkpsANRGek3E93fXUEaw9Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 11 Apr 2022 at 22:11, John Naylor <john(dot)naylor(at)enterprisedb(dot)com> wrote:
>
> On Mon, Apr 11, 2022 at 5:34 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> > With this particular test, v15 is about 15% *slower* than v14. I
> > didn't know what to blame at first, so I tried commenting out the sort
> > specialisations and got the results in the red bars in the graph. This
> > made it about 7.5% *faster* than v14. So looks like this patch is to
> > blame. I then hacked the comparator function that's used in the
> > specialisations for BIGINT to comment out the tiebreak to remove the
> > indirect function call, which happens to do nothing in this 1 column
> > sort case. The aim here was to get an idea what the performance would
> > be if there was a specialisation for single column sorts. That's the
> > yellow bars, which show about 10% *faster* than master.
>
> Thanks for investigating! (I assume you meant 10% faster than v14?)

Yes, I did mean to say v14. (I'm too used to comparing everything to master)

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2022-04-12 00:45:23 Re: Skip partition tuple routing with constant partition key
Previous Message Peter Smith 2022-04-12 00:40:14 Re: row filtering for logical replication