Re: Use simplehash.h instead of dynahash in SMgr

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Use simplehash.h instead of dynahash in SMgr
Date: 2021-04-30 03:38:10
Message-ID: CAApHDvrrPxfJ0D+bF4+gzKWi+5bZAFCiwdF6zDe=7wU6+uh2Jg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I've attached an updated patch. I forgot to call SH_ENTRY_CLEANUP,
when it's defined during SH_RESET.

I also tided up a couple of comments and change the code to use
pg_rotate_right32(.., 31) instead of adding a new function for
pg_rotate_left32 and calling that to shift left 1 bit.

David

Attachment Content-Type Size
v3-0001-Use-simplehash.h-hashtables-in-SMgr.patch application/octet-stream 10.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-04-30 04:38:04 Re: [BUG] "FailedAssertion" reported when streaming in logical replication
Previous Message Craig Ringer 2021-04-30 03:23:56 Re: [PATCH] Identify LWLocks in tracepoints