| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Nitin Motiani <nitinmotiani(at)google(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH v1] Fix for bug #19770 : Reject NO INHERIT not-null constraints copied by LIKE to partitioned tables |
| Date: | 2026-10-27 06:51:16 |
| Message-ID: | CAApHDvrqcGGaR-K4B3t1Ck8eqP1XaEoEeFSMeXnbaZLEuxTCRg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 23 Oct 2026 at 01:48, Nitin Motiani <nitinmotiani(at)google(dot)com> wrote:
> Should the release notes also explicitly state that NULLs must be
> found and fixed directly on the partitions, because a 'delete ...
> where col is null' on the parent table would not delete anything?
It's a good point. I'd forgotten that the WHERE IS NOT NULL would
become a gating qual. I added some further wording to the commit
message.
> The existing test on HEAD copies a table that has both a NO INHERIT
> CHECK constraint and a NO INHERIT NOT NULL constraint. With the v2,
> that statement now fails on the NOT NULL constraint because the
> not-null constraints are stored during DefineRelation() before the
> CHECK constraints are added. With VERBOSITY verbose, I got this :
I swapped the order of those tests so they test each thing correctly.
I pushed the result after swapping the error message over to what Chao
mentioned. I'd debated that at the time, but opted for the nearby one
at the time. It's now the same as for normal CREATE TABLE.
David
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | shveta malik | 2026-10-27 06:50:04 | Re: Proposal: Conflict log history table for Logical Replication |