| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Window Function "Run Conditions" |
| Date: | 2022-04-07 07:01:13 |
| Message-ID: | CAApHDvrqaRrmS6Ee7hQ5NfRpfNGGS+Y0dhootWvkyUxMeoTm7w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 7 Apr 2022 at 15:41, Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> + * We must keep the original qual in place if there is a
> + * PARTITION BY clause as the top-level WindowAgg remains in
> + * pass-through mode and does nothing to filter out unwanted
> + * tuples.
> + */
> + *keep_original = false;
>
> The comment talks about keeping original qual but the assignment uses the value false.
> Maybe the comment can be rephrased so that it matches the assignment.
Thanks. I've just removed that comment locally now. You're right, it
was out of date.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2022-04-07 07:14:01 | Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN |
| Previous Message | Michael Paquier | 2022-04-07 06:58:46 | Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN |