Re: Fixup some appendPQExpBuffer() calls

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fixup some appendPQExpBuffer() calls
Date: 2025-04-16 23:44:57
Message-ID: CAApHDvroakZRqVFXrQ5FizwYZ9ck93OT2k5kkJkBCeoe9HVw9Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 14 Apr 2025 at 19:39, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> 1) I should commit the attached 0002 patch now, or;
> 2) Should commit only the new-to-v18 ones now, or;
> 3) do nothing.
>
> I think #3 isn't a good option as we (or I) have made efforts in the
> past to keep these in check. Also, for me, #2 isn't ideal as if I do
> this next year for v19, I'll need to ignore the older inconsistencies,
> and I'd rather not have to do that, so I vote for #1.
>
> Any other opinions?

To reduce the above 3 options down to two, I just pushed the ones that
were new to v18. The attached patch handles the ones that were added
prior to v18.

The options now are:
1) Commit the attached to master
2) Do nothing.

I'd like to do #1.

David

Attachment Content-Type Size
v2-0001-Fixup-various-older-usages-of-appendPQExpBuffer.patch application/octet-stream 9.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2025-04-17 00:47:11 Re: New committer: Jacob Champion
Previous Message Tom Lane 2025-04-16 23:28:44 Re: jsonapi: scary new warnings with LTO enabled