From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | David Rowley <drowley(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Add Result Cache executor node (take 2) |
Date: | 2021-04-02 21:43:43 |
Message-ID: | CAApHDvrgt9ZKQghHBnNvvSwTb2EE5c6QF+uqa=740awcoJ1juQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Sat, 3 Apr 2021 at 09:47, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Since this commit I am seeing
>
> In file included from /home/andres/src/postgresql/src/include/postgres.h:46,
> from /home/andres/src/postgresql/src/backend/executor/nodeResultCache.c:67:
> /home/andres/src/postgresql/src/backend/executor/nodeResultCache.c: In function ‘entry_purge_tuples’:
> /home/andres/src/postgresql/src/backend/executor/nodeResultCache.c:290:27: warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits]
> 290 | Assert(rcstate->mem_used >= 0);
> | ^~
Those were last-minute additions and seems not well thought through.
I've now removed them.
Thanks for the report.
David
From | Date | Subject | |
---|---|---|---|
Next Message | Jaime Casanova | 2021-04-02 23:53:37 | Re: pgsql: Add 'noError' argument to encoding conversion functions. |
Previous Message | David Rowley | 2021-04-02 21:42:04 | pgsql: Remove useless Asserts in Result Cache code |