Re: BUG #19783: Sorted GROUPING SETS return a grouping column's value in a set that leaves it out

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
Cc: alpkeles99(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19783: Sorted GROUPING SETS return a grouping column's value in a set that leaves it out
Date: 2026-10-29 20:57:51
Message-ID: CAApHDvrWHry4ESjxf2p1n4UEYLGnzqj4L63tL_jGX+fb-hbQgw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, 28 Oct 2026 at 18:41, Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> wrote:
> Thanks for the patch, LGTM.
>
> Is there a reason though for not using else if (node->groupingSets)
> for the new block instead of just else?

I went with "else if (aggstate->all_grouped_cols != NIL)". Pushed
after spending a bit more time on the commit message.

Thanks for looking.

David

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Gaurav Singh 2026-10-29 21:00:34 postgres_fdw returns wrong rows for age(timestamptz, timestamptz) filters
Previous Message Tom Lane 2026-10-29 20:47:18 Re: BUG #19411: libpq 16.x exhibits a memory leak when connections are repeatedly created and destroyed