| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Richard Guo <guofenglinux(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Protecting allocator headers with Valgrind |
| Date: | 2023-04-16 05:29:34 |
| Message-ID: | CAApHDvrV7WQ2dqJeT2i3HFPK3UFoadafRdDoE6W7H=P=_dmQSQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 16 Apr 2023 at 03:26, Noah Misch <noah(at)leadboat(dot)com> wrote:
> Not objecting. I think the original Valgrind integration refrained from this
> because it would have added enough Valgrind client requests to greatly slow
> Valgrind runs. Valgrind reduced the cost of client requests in later years,
> so this new conclusion is reasonable.
I tested that. It's not much slowdown:
time make installcheck
Unpatched: real 79m36.458s
Patched: real 81m31.589s
I forgot to mention, I pushed the patch yesterday.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mikael Kjellström | 2023-04-16 07:54:15 | Re: Direct I/O |
| Previous Message | Pavel Stehule | 2023-04-16 04:28:13 | idea: multiple arguments to_regclass function |