| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Shaik Mohammad Mujeeb <mujeeb(dot)sk(at)zohocorp(dot)com>, ilyaevdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, mujeebskdev <mujeeb(dot)sk(dot)dev(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add comment explaining why queryid is int64 in pg_stat_statements |
| Date: | 2025-05-20 02:03:37 |
| Message-ID: | CAApHDvrUSHnBqYkPRZfMWjck0+qKDmTFZJq-SYZ4cs-pPBV6NA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 20 May 2025 at 03:05, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> Or why not store query IDs as int64_t
> internally, too?
I had the same thought. Changing to int64 seems like a good and less
bug-prone tidy-up. I expected we ended up with uint64 as the previous
type was uint32, and uint64 is the natural selection for widening that
to 64 bits.
Aside from the struct field types changing for Query.queryId,
PlannedStmt.queryId and PgBackendStatus.st_query_id, the
external-facing changes are limited to:
1. pgstat_report_query_id() now returns int64 instead of uint64
2. pgstat_get_my_query_id() now returns int64 instead of uint64
3. pgstat_report_query_id()'s first input parameter is now int64
If we were to clean this up, then I expect it's fine to wait until
v19, as it's not really a problem that's new to v18.
David
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Change-internal-queryid-type-to-int64.patch | application/octet-stream | 19.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-05-20 02:29:25 | Re: Prevent an error on attaching/creating a DSM/DSA from an interrupt handler. |
| Previous Message | Tatsuo Ishii | 2025-05-20 01:40:18 | Adding null patch entry to cfbot/CommitFest |