Re: another autovacuum scheduling thread

On Fri, 27 Mar 2026 at 05:49, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Thu, Mar 26, 2026 at 01:28:16PM +1300, David Rowley wrote:
> > A review:
>
> Thanks. I believe I've addressed all your feedback.

It might just be a personal taste thing, but I'd have done the
following differently:

+ if (autovacuum_freeze_score_weight != 0.0 ||
+ autovacuum_multixact_freeze_score_weight != 0.0 ||
+ autovacuum_vacuum_score_weight != 0.0 ||
+ autovacuum_vacuum_insert_score_weight != 0.0 ||
+ autovacuum_analyze_score_weight != 0.0)
+ list_sort(tables_to_process, TableToProcessComparator);

I'd have done:

+ table->score = scores.max;
+ sort_required |= (scores.max != 0.0);
+ tables_to_process = lappend(tables_to_process, table);

...

if (sort_required)
list_sort(tables_to_process, TableToProcessComparator);

But, I'm fine if you'd rather keep it the way you have it.

No further comments at this stage.

Thanks for working on this.

David