| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Subject: | Re: Add proper planner support for ORDER BY / DISTINCT aggregates |
| Date: | 2022-07-26 22:37:26 |
| Message-ID: | CAApHDvrRGoVRthOvA4CBfFy5Km-dSFGQNnQ_SAN7pCytyxxpMA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 26 Jul 2022 at 12:01, Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> sort order the the planner chooses is simply : there is duplicate `the`
I think the first "the" should be "that"
> + /* mark this aggregate is covered by 'currpathkeys' */
>
> is covered by -> as covered by
I think it was shortened from "mark that this aggregate", but I
dropped "that" to get the comment to fit on a single line. Swapping
"is" for "as" makes it better. Thanks.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2022-07-26 22:38:53 | Re: explain_regress, explain(MACHINE), and default to explain(BUFFERS) (was: BUFFERS enabled by default in EXPLAIN (ANALYZE)) |
| Previous Message | Thomas Munro | 2022-07-26 22:31:18 | Re: fairywren hung in pg_basebackup tests |