Re: ORDER BY pushdowns seem broken in postgres_fdw

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>
Cc: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Subject: Re: ORDER BY pushdowns seem broken in postgres_fdw
Date: 2021-07-22 07:44:54
Message-ID: CAApHDvrOrvY3j3uMaa8hVCyAzNKZuDZK-2dNe3zm-u+VB=QGkw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 22 Jul 2021 at 19:00, Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io> wrote:
> Please find it reattached.

+-- This will not be pushed either
+explain verbose select * from ft2 order by c1 using operator(public.<^);
+ QUERY PLAN
+-------------------------------------------------------------------------------
+ Sort (cost=190.83..193.33 rows=1000 width=142)

Can you also use explain (verbose, costs off) the same as the other
tests in that area. Having the costs there would never survive a run
of the buildfarm. Different hardware will produce different costs, e.g
32-bit hardware might cost cheaper due to narrower widths.

History lesson: costs off was added so we could test plans. Before
that, I don't think that the regression tests had any coverage for
plans. Older test files still likely lack much testing with EXPLAIN.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2021-07-22 07:45:47 Re: A (but copied many) typo of char-mapping tables
Previous Message Ronan Dunklau 2021-07-22 07:40:30 Re: postgres_fdw: Handle boolean comparison predicates