| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Redundant/mis-use of _(x) gettext macro? |
| Date: | 2026-04-24 12:43:43 |
| Message-ID: | CAApHDvrMyX4dVfQa11shF8rQxC9EjAQJ0D77gP6LG+ptXnBHFg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 25 Apr 2026 at 00:14, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2026-Apr-24, Peter Smith wrote:
>
> > OK. Including the comma within a larger translated string seems like a
> > better idea.
> >
> > Since you now have the list `length`, I wondered why not simplify
> > further to use list_nth indexing? Then you can remove
> > `foreach_current_index` and `lc`.
>
> WFM.
Wouldn't it be simpler to put the comma on the other end of the name
and use that if (foreach_current_index(lc) > 0) ?
Or was this to reuse a translation and you didn't want to swap
"\"%s\", " for , "\"%s\" ?
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-04-24 13:08:04 | Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks |
| Previous Message | Ashutosh Bapat | 2026-04-24 12:38:07 | Re: Property graph: fix error handling when dropping non-existent label property |