| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Refactoring SysCacheGetAttr to know when attr cannot be NULL |
| Date: | 2023-03-23 08:52:35 |
| Message-ID: | CAApHDvrJVqN3thT36_UHUULQDKHxn5-d=5haHQjXmLGb5pbVzg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 14 Mar 2023 at 02:19, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> Rebased v3 on top of recent conflicting ICU changes causing the patch to not
> apply anymore. Also took another look around the tree to see if there were
> missed callsites but found none new.
I had a look at this. It generally seems like a good change.
One thing I thought about while looking is it stage 2 might do
something similar for SearchSysCacheN. I then wondered if we're more
likely to want to keep the localised __FILE__, __LINE__ and __func__
in the elog for those or not. It's probably less important that we're
losing those for this change, but worth noting here at least in case
nobody else thought of it.
I only noticed in a couple of places you have a few lines at 80 chars
before the LF. Ideally those would wrap at 79 so that it's 80
including LF. No big deal though.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | wangw.fnst@fujitsu.com | 2023-03-23 09:11:29 | RE: Data is copied twice when specifying both child and parent table in publication |
| Previous Message | Dilip Kumar | 2023-03-23 08:45:12 | Re: Error "initial slot snapshot too large" in create replication slot |