Re: Add a bound check to TidRangeEval

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Junwang Zhao <zhjwpku(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add a bound check to TidRangeEval
Date: 2025-06-14 05:20:42
Message-ID: CAApHDvrFpttry31n1DZLPpmVJoeeUm8YJgSAFHcbrYwdRn=Zgg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, 14 Jun 2025 at 16:10, Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:
>
> On Sat, Jun 14, 2025 at 11:27 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > How about adding "We don't bother validating that trss_mintid is less
> > than or equal to trss_maxtid, as the scan_set_tidrange() table AM
> > function will detect that."
>
> Sounds good to me. This will naturally direct readers to the
> comments in scan_set_tidrange.

Thanks for looking. Pushed, after changing "detect" into "handle".

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2025-06-14 05:26:52 Re: pg_recvlogical cannot create slots with failover=true
Previous Message Amit Kapila 2025-06-14 04:46:04 Re: Logical Replication slot disappeared after promote Standby