| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Reducing the chunk header sizes on all memory context types |
| Date: | 2022-08-30 01:04:46 |
| Message-ID: | CAApHDvrED=moCbAzWte93XTXP9BwjS882Dq0FNdSjNsjsC7rmg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 30 Aug 2022 at 12:22, Tomas Vondra
<tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
> I also suggested doing a similar check in MemoryChunkGetPointer, so that
> we catch the issue earlier - right after we allocate the chunk. Any
> opinion on that?
I think it's probably a good idea. However, I'm not yet sure if we can
keep it as a macro or if it would need to become a static inline
function to do that.
What I'd really have wished for is a macro like AssertPointersEqual()
that spat out the two pointer values. That would probably have saved
more time on this issue.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2022-08-30 01:16:00 | Re: Reducing the chunk header sizes on all memory context types |
| Previous Message | Michael Paquier | 2022-08-30 00:57:10 | Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~ |