| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)postgresql(dot)org, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | Re: shadow variables - pg15 edition |
| Date: | 2022-10-12 01:50:58 |
| Message-ID: | CAApHDvr2fh-ann9zSOYKKR0wbDAq337=wo_A=1b6ebOkQuzR=Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 12 Oct 2022 at 14:39, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> -Wshadow=compatible-local causes one extra warning in postgres.c with
> -DWRITE_READ_PARSE_PLAN_TREES:
> postgres.c: In function ‘pg_rewrite_query’:
> postgres.c:818:37: warning: declaration of ‘query’ shadows a parameter [-Wshadow=compatible-local]
> 818 | Query *query = lfirst_node(Query, lc);
> | ^~~~~
> postgres.c:771:25: note: shadowed declaration is here
> 771 | pg_rewrite_query(Query *query)
> | ~~~~~~~^~~~~
>
> Something like the patch attached would deal with this one.
Thanks for finding that and coming up with the patch. It looks fine to
me. Do you want to push it?
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-10-12 02:09:41 | Re: Issue in GIN fast-insert: XLogBeginInsert + Read/LockBuffer ordering |
| Previous Message | Michael Paquier | 2022-10-12 01:39:49 | Re: shadow variables - pg15 edition |