| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | li(dot)evan(dot)chao(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)lists(dot)postgresql(dot)org, pramsey(at)cleverelephant(dot)ca, ojford(at)gmail(dot)com, peter(at)eisentraut(dot)org, krasiyan(at)gmail(dot)com, vik(at)postgresfriends(dot)org, andrew(at)tao11(dot)riddles(dot)org(dot)uk, david(at)fetter(dot)org |
| Subject: | Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options |
| Date: | 2025-10-22 04:18:31 |
| Message-ID: | CAApHDvqyCEGc7taz3OiF-LMsWmUVhgmGErWR9rH+wtFU-U-JCg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 20 Oct 2025 at 16:59, Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
>
> > A very trivial commit:
> >
> > ```
> > + else
> > +
> > + /*
> > + * For other cases we have no idea what position of row callers would
> > + * fetch next time. Also for relpos < 0 case (we go backward), we
> > + * cannot set mark either. For those cases we always set mark at 0.
> > + */
> > + mark_pos = 0;
> > ```
> >
> > The empty line after “else” is not needed.
>
> That was added by pgindent.
If it's written down somewhere, I can't find it, but the rule we
normally follow here is; don't use braces if the code block has a
single statement without any comments that appear on a separate line.
Otherwise, use braces.
Since your comments are not on the same line as the statement, it
should have braces. I imagine that's why pgindent is "acting weird".
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2025-10-22 04:31:46 | Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue |
| Previous Message | AIX PG user | 2025-10-22 03:52:39 | Re: AIX support |