| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | James Coleman <jtc331(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays |
| Date: | 2021-05-23 06:36:03 |
| Message-ID: | CAApHDvqudeFZa9zmdhXUE-j+98K4Xg3BNsJ+k9nTqw1Rz_NLgQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 8 May 2021 at 20:29, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Sat, 8 May 2021 at 20:17, Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> > + if (!OidIsValid(saop->negfuncid))
> > + record_plan_function_dependency(root, saop->hashfuncid);
> >
> > Is there a typo in the second line ? (root, saop->negfuncid)
>
> Yeah, that's a mistake. Thanks for checking it.
I've attached a patch which fixes the mistake mentioned above.
Also, dropped the RMT from the thread. I only introduced them when I
wanted some input about if hashing NOT IN should be included in PG14.
Nobody seems to think that should be done.
David
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Speedup-NOT-IN-with-a-set-of-Consts.patch | application/octet-stream | 20.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2021-05-23 07:01:30 | RelOptInfo.all_partrels does not seem to do very much |
| Previous Message | Bharath Rupireddy | 2021-05-23 05:40:28 | Re: Fixing the docs for ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION |