Re: Something seems weird inside tts_virtual_copyslot()

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Something seems weird inside tts_virtual_copyslot()
Date: 2023-12-07 08:29:41
Message-ID: CAApHDvqpgiu3yODWNpSE47pwq4g1HN5H1ObyDBHJuwAkVynG1w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 1 Dec 2023 at 14:30, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Fri, 1 Dec 2023 at 13:14, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > So I think adding an assert to ExecCopySlot(), perhaps with a comment saying
> > that the restriction could be lifted with a bit of work, would be fine.
>
> How about the attached? I wrote the comment you mentioned and also
> removed the Assert from tts_virtual_copyslot().

I looked over this again and didn't see any issues, so pushed the patch.

Thanks for helping with this.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Junwang Zhao 2023-12-07 08:37:36 Re: Make COPY format extendable: Extract COPY TO format implementations
Previous Message Peter Eisentraut 2023-12-07 08:25:41 Re: remaining sql/json patches