| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Vik Fearing <vik(at)postgresfriends(dot)org>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Erwin Brandstetter <brsaweda(at)gmail(dot)com> |
| Subject: | Re: Allow WindowFuncs prosupport function to use more optimal WindowClause options |
| Date: | 2022-10-18 00:05:23 |
| Message-ID: | CAApHDvqkYaPnfRkE+gdme0wVZiyFsJQYgZx=T15+5_qySjwfnw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for having a look at this.
On Fri, 14 Oct 2022 at 10:52, Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> + req->frameOptions = (FRAMEOPTION_ROWS |
> + FRAMEOPTION_START_UNBOUNDED_PRECEDING |
> + FRAMEOPTION_END_CURRENT_ROW);
>
> The bit combination appears multiple times in the patch.
> Maybe define the combination as a constant in supportnodes.h and reference it in the code.
I don't believe supportnodes.h has any business having any code that's
related to actual implementations of the support request type. If we
were to have such a definition then I think it would belong in
windowfuncs.c. I'd rather see each implementation of the support
request spell out exactly what they mean, which is what the patch does
already.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2022-10-18 00:47:35 | Re: havingQual vs hasHavingQual buglets |
| Previous Message | David Rowley | 2022-10-18 00:00:19 | Re: Warning about using pg_stat_reset() and pg_stat_reset_shared() |