Re: Add proper planner support for ORDER BY / DISTINCT aggregates

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Zhihong Yu <zyu(at)yugabyte(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Richard Guo <guofenglinux(at)gmail(dot)com>, Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Subject: Re: Add proper planner support for ORDER BY / DISTINCT aggregates
Date: 2022-08-02 21:48:49
Message-ID: CAApHDvqk1iT4hjVj+Ay4YCFmrsXGnXaDcgTLgUeFwH6Qb0MrBg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 3 Aug 2022 at 07:31, Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> On Tue, Aug 2, 2022 at 11:02 AM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
>> I was looking at the final patch and noticed that setno field in agg_presorted_distinctcheck struct is never used.

> Looks like setoff field is not used either.

Thanks for the report. It seems transno was unused too.

I just pushed a commit to remove all 3.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2022-08-02 21:57:38 Re: [PATCH] Expose port->authn_id to extensions and triggers
Previous Message Jacob Champion 2022-08-02 21:48:33 Re: Proposal: Support custom authentication methods using hooks