Re: Incorrect Assert in BufFileSize()?

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>
Subject: Re: Incorrect Assert in BufFileSize()?
Date: 2024-05-14 10:58:29
Message-ID: CAApHDvqiwifZiip=swWjRNA1Zo9sO9c0CMvfR5M8nvbq1X4TRw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 3 May 2024 at 16:03, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> I'm trying to figure out why BufFileSize() Asserts that file->fileset
> isn't NULL, per 1a990b207.

I was hoping to get some feedback here.

Here's a patch to remove the Assert(). Changing it to
Assert(file->files != NULL); doesn't do anything useful.

David

Attachment Content-Type Size
remove_bogus_Assert_from_BufFileSize.patch application/octet-stream 445 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2024-05-14 11:03:57 Re: Fix resource leak (src/backend/libpq/be-secure-common.c)
Previous Message Elena Indrupskaya 2024-05-14 10:34:56 Re: First draft of PG 17 release notes