From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
---|---|
To: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Julien Rouhaud <rjuju123(at)gmail(dot)com> |
Subject: | Strange code in EXPLAIN for queryid |
Date: | 2021-08-08 11:56:41 |
Message-ID: | CAApHDvqhSLYpSU_EqUdN39w9Uvb8ogmHV7_3YhJ0S3aScGBjsg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I was wondering about the following code in explain.c
char buf[MAXINT8LEN + 1];
pg_lltoa(plannedstmt->queryId, buf);
ExplainPropertyText("Query Identifier", buf, es);
I thought it was a bit strange that we don't just use
ExplainPropertyInteger() instead of going to the trouble of building
the string with pg_lltoa().
On looking a little closer I also saw that plannedstmt->queryId is a
uint64. I guess that we're showing this as an int64 so that it
matches the queryid column in the pg_stat_statements view? If so, I
think it's worth a comment to mention why we're not using
ExplainPropertyUInteger.
Any objection to applying the attached to pg14 and master?
David
Attachment | Content-Type | Size |
---|---|---|
clarify_why_queryid_is_signed_rather_than_unsigned.patch | application/octet-stream | 777 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2021-08-08 12:28:10 | Re: Use generation context to speed up tuplesorts |
Previous Message | David Rowley | 2021-08-08 11:29:27 | Re: Extra code in commit_ts.h |