Re: Fix wrong filename in header comment of gin_tuple.h

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, tomas(at)vondra(dot)me
Subject: Re: Fix wrong filename in header comment of gin_tuple.h
Date: 2025-09-22 01:42:15
Message-ID: CAApHDvqYbtjO0QCcayBzPfZ6QDQHKVT5HZV_syoh75gNXi6r8g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 22 Sept 2025 at 12:57, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>
> On Mon, Sep 22, 2025 at 9:53 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > I was just working on a script to find others and it highlighted a
> > bunch more. Do you still want to do this one, or should I take them
> > all in one fell swoop?
>
> Makes sense to handle them all together. Feel free to take this one
> as part of the larger cleanup.

Thanks.

"script" didn't amount to much more than running:

git grep "^\s\*\s.*\.[ch]$" -- *.[ch] | sed -r "s/ \*\s{1,}(.*)/\1/"

and then filtering every line where the text left of the ':' didn't
end in the text right of the ':'. There are about 287 lines out of
4302 lines that don't match that. So a quick eyeball scan of the 287
lines seemed to work to check for abnormalities. Almost all of the
remainder are just mentioning a filename in a sentence rather than for
the identification related stuff.

Pushed the found abnormalities, which included Chao's

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yang Oreo 2025-09-22 01:48:10 Re: Meson0.57.2 setup failed with option -Duuid=ossp
Previous Message Quan Zongliang 2025-09-22 01:27:38 Re: Doc: add XML ID attributes to <varlistentry> tags for create_foreign_table, alter_foreign_table