| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Reducing the chunk header sizes on all memory context types |
| Date: | 2022-08-30 01:16:00 |
| Message-ID: | CAApHDvqUgfMj1=89K1g1q3i2y1N3b94sDAcd5dKHXpWenhf80w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 30 Aug 2022 at 12:45, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> I think the existing sentinel check looks wrong:
>
> if (!sentinel_ok(chunk, slab->chunkSize))
>
> shouldn't that be passing the pointer rather than the chunk?
Here's v2 of the slab-fix patch.
I've included the sentinel check fix. This passes make check-world
for me when do a 32-bit build on my x86_64 machine and adjust
pg_config.h to set MAXIMUM_ALIGNOF to 8.
Any chance you could run make check-world on your 32-bit Raspberry PI?
I'm also wondering if this should also be backpatched back to v10,
providing the build farm likes it well enough on master.
| Attachment | Content-Type | Size |
|---|---|---|
| slab-fix_v2.patch | text/plain | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ken Kato | 2022-08-30 01:19:28 | Re: pg_stat_wal: tracking the compression effect |
| Previous Message | David Rowley | 2022-08-30 01:04:46 | Re: Reducing the chunk header sizes on all memory context types |