| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix bogus use of "long" in aset.c |
| Date: | 2025-10-30 01:51:52 |
| Message-ID: | CAApHDvqRGxd9H8OZHvArZ3t-CDXcxr9uBXHwwx+0+BAOWDmdqA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 30 Oct 2025 at 13:24, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > The reason I left it an unsigned type was that the check is doing: if
> > (chsize + ALLOC_CHUNKHDRSZ != blk_used), so we'd still catch this with
> > an unsigned type, even if it wrapped due to going negative due to a
> > bogus freeptr. Changing to a signed type would leave us with a few
> > tests comparing signed to unsigned types.
>
> Yeah, that's fair. I'm content with what you have.
Thanks for the reviews. I've pushed and backpatched to 13.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-10-30 01:56:06 | Re: tuple radix sort |
| Previous Message | Arne Roland | 2025-10-30 01:23:22 | Re: apply_scanjoin_target_to_paths and partitionwise join |