| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> |
| Subject: | Re: call popcount32/64 directly on non-x86 platforms |
| Date: | 2021-08-12 00:13:09 |
| Message-ID: | CAApHDvqPDyUpqWuoKZZmvcZsatkcutR-ybR6xbaZXsjhsGPTuA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 12 Aug 2021 at 05:11, John Naylor <john(dot)naylor(at)enterprisedb(dot)com> wrote:
> 0001 moves some declarations around so that "slow" popcount functions are called directly on non-x86 platforms.
I was wondering if there was a reason that you didn't implement this
by just changing pg_popcount32 and pg_popcount64 to be actual
functions rather than function pointers when TRY_POPCNT_FAST is not
defined? These functions would then just return
pg_popcountNN_slow(word);
This would save from having to change all the current callers of the
functions to use the macro instead. That might be nice for any
extensions which are using these functions.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2021-08-12 00:53:40 | Re: 2021-08-12 release announcement draft |
| Previous Message | Isaac Morland | 2021-08-12 00:05:46 | Re: 2021-08-12 release announcement draft |