| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Greg Burd <greg(at)burd(dot)me> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add bms_offset_members() function for bitshifting Bitmapsets |
| Date: | 2026-04-19 23:52:58 |
| Message-ID: | CAApHDvqOgtX2MqaPmPmPET7=ySszzuoP3MLSUbWZit_V30VBLg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 20 Apr 2026 at 07:22, Greg Burd <greg(at)burd(dot)me> wrote:
> I applied, tested, and reviewed these changes. Thanks for doing this, only a few small things jumped out.
Many thanks. I took all of those suggestions.
> SELECT test_bms_offset_members('(b 1)', -2147483648);
I made that one use member 0 instead of 1. That'll mean "new_highest"
goes to INT_MIN rather than INT_MIN + 1.
David
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Introduce-bms_offset_members-function.patch | application/octet-stream | 20.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Koval | 2026-04-20 00:04:28 | Re: MERGE PARTITIONS and DEPENDS ON EXTENSION. |
| Previous Message | Michael Paquier | 2026-04-19 22:18:37 | Re: some extra warnings from MSVC |