| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Vik Fearing <vik(at)postgresfriends(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Subject: | Is the testing a bit too light on GROUP BY DISTINCT? |
| Date: | 2021-06-21 11:19:45 |
| Message-ID: | CAApHDvqDoSVmM=GfFizAoa7axWQsD=zBP3=CXWPyJMDO9W6TQw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
In [1], Yaoguang reported an Assert failure in expand_grouping_sets.
Since beta2 deadline is looming, I pushed a quick fix for that.
As mentioned over on bugs, only 1 test triggers that code and because
the List of IntLists always had an empty list as the first element due
to the code just above sorting the top-level List by the number of
elements each of the contained IntLists, the NIL was always at the
start of the top-level List.
It wasn't too hard to modify the test to change that.
I wonder if the testing for the feature is just a bit too light.
Would it maybe be worth adding a GROUP BY DISTINCT with GROUPING SETS test?
Any thoughts?
David
[1] https://www.postgresql.org/message-id/17067-665d50fa321f79e0@postgresql.org
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2021-06-21 11:23:56 | Re: SSL/TLS instead of SSL in docs |
| Previous Message | Brar Piening | 2021-06-21 11:11:27 | Re: Doc patch for Logical Replication Message Formats (PG14) |