Thanks for the review.
On Sat, 24 Oct 2026 at 17:48, shihao zhong <zhong950419(at)gmail(dot)com> wrote:
> The patch fixes the cases from the report for me. Two small things.
>
> 1. simplehash rounds the size up to a power of 2, so the empty table
> can still be twice hash_mem. With work_mem = 1GB, a plain EXPLAIN of
> the recursive query zeroes 4 GB. Halving the limit fixes it.
> hash_choose_num_buckets() does the same.
While it is true that simplehash will make the bucket count the next
power of 2 value, I didn't do this as I wanted to restore what we did
prior to 8f29467c5 in terms of the hard limit.
> 2. Plain EXPLAIN still builds the table. nodeAgg skips it.
Seems unrelated and I don't recall anyone complaining. Not something I
think we should adjust last minute before v19 goes out the door.
Now pushed.
David