From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
---|---|
To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com> |
Subject: | Re: shadow variables - pg15 edition |
Date: | 2022-10-04 01:27:09 |
Message-ID: | CAApHDvq4dg7M+_imHZJ3bxNRW53EBkDuo6jxmSnMtrtX_Br3fQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, 30 Aug 2022 at 17:44, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> Would you check if any of these changes are good enough ?
I looked through v5.txt and modified it so that the fix for the shadow
warnings are more aligned to the spreadsheet I created.
I also fixed some additional warnings which leaves just 5 warnings. Namely:
../../../src/include/utils/elog.h:317:29: warning: declaration of
‘_save_exception_stack’ shadows a previous local
../../../src/include/utils/elog.h:318:39: warning: declaration of
‘_save_context_stack’ shadows a previous local
../../../src/include/utils/elog.h:319:28: warning: declaration of
‘_local_sigjmp_buf’ shadows a previous local
../../../src/include/utils/elog.h:320:22: warning: declaration of
‘_do_rethrow’ shadows a previous local
pgbench.c:7509:40: warning: declaration of ‘now’ shadows a previous local
The first 4 of those are due to a nested PG_TRY(). The final one I
just ran out of inspiration on what to rename the variable to.
If there are no objections then I'll push this in the next day or 2.
David
Attachment | Content-Type | Size |
---|---|---|
rename_shadowed_vars.patch | text/plain | 46.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | kuroda.hayato@fujitsu.com | 2022-10-04 02:26:49 | RE: [Proposal] Add foreign-server health checks infrastructure |
Previous Message | Jeff Davis | 2022-10-04 00:41:56 | Re: New strategies for freezing, advancing relfrozenxid early |