| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: tuplesort Generation memory contexts don't play nicely with index builds |
| Date: | 2022-06-30 03:54:23 |
| Message-ID: | CAApHDvq2iQ0WygUCacYfSWWsbXBUFwrjtqf1EV=VpnFQP1b7wA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 29 Jun 2022 at 12:59, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> I noticed while doing some memory context related work that since we
> now use generation.c memory contexts for tuplesorts (40af10b57) that
> tuplesort_putindextuplevalues() causes memory "leaks" in the
> generation context due to index_form_tuple() being called while we're
> switched into the state->tuplecontext.
I've attached a draft patch which changes things so that we don't use
generation contexts for sorts being done for index builds.
David
| Attachment | Content-Type | Size |
|---|---|---|
| dont_use_gencxt_for_index_builds.patch | text/plain | 7.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2022-06-30 03:56:38 | Add index item for MERGE. |
| Previous Message | Nikolay Shaplov | 2022-06-30 03:47:48 | Re: [PATCH] minor reloption regression tests improvement |