| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: ExecRTCheckPerms() and many prunable partitions |
| Date: | 2021-06-30 22:51:51 |
| Message-ID: | CAApHDvpzCbPGGtrF7xaVNjP11HJDgK=nqaZqcE6QkhOXf_+Lqw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 1 Jul 2021 at 02:58, Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
>
> On Wed, Jun 30, 2021 at 23:34 David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>> + while ((rti = bms_next_member(checkPermRels, rti)) > 0)
>> {
>> - RangeTblEntry *rte = (RangeTblEntry *) lfirst(l);
>> + RangeTblEntry *rte = (RangeTblEntry *) list_nth(rangeTable, rti - 1);
>>
>> I'd have expected >= 0 rather than > 0.
>
> Hmm, a valid RT index cannot be 0, so that seems fine to me. Note that RT indexes are added as-is to that bitmapset, not after subtracting 1.
Oh, you're right. My mistake.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2021-06-30 22:53:42 | Re: Small clean up in nodeAgg.c |
| Previous Message | David Rowley | 2021-06-30 22:47:41 | Re: New committers: Daniel Gustafsson and John Naylor |