| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix a couple of misuages of bms_num_members() |
| Date: | 2020-08-25 22:52:49 |
| Message-ID: | CAApHDvpv3c0d5oEeH96gr_RJjbqOJhSSqU1WTp_S3trc9aUx-A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 26 Aug 2020 at 01:18, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
>
> On Wed, Aug 26, 2020 at 12:51:37AM +1200, David Rowley wrote:
> >I noticed today there are a few places where we use bms_num_memebers()
> >where we really should be using bms_membership(). These are not bugs,
> >they're mostly just bad examples to leave laying around, at best, and
> >a small performance penalty, at worst.
> >
> >Unless there are any objections, I plan to push this to master only in
> >about 10 hours time.
> >
>
> Seems OK to me. Thanks.
Thanks for having a look. Pushed.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2020-08-25 22:54:33 | Re: [PATCH] Fix Uninitialized scalar variable (UNINIT) (src/backend/access/heap/heapam_handler.c) |
| Previous Message | Alvaro Herrera | 2020-08-25 22:45:10 | Re: [PATCH] Fix Uninitialized scalar variable (UNINIT) (src/backend/access/heap/heapam_handler.c) |