| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Making aggregate deserialization (and WAL receive) functions slightly faster |
| Date: | 2023-10-17 07:39:52 |
| Message-ID: | CAApHDvps5q4+CoJawcPr=jm0WmsJRWTRZXMS8UVcrepcwYAG3Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 16 Oct 2023 at 05:56, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> * in initStringInfoFromString, str->maxlen must be set to len+1 not len
>
> * comment in exec_bind_message doesn't look like pgindent will like it
>
> * same in record_recv, plus it has a misspelling "Initalize"
>
> * in stringinfo.c, inclusion of pg_bitutils.h seems no longer needed
Thank you for looking again. I've addressed all of these in the attached.
> I guess the next question is whether we want to stop here or
> try to relax the requirement about NUL-termination. I'd be inclined
> to call that a separate issue deserving a separate commit, so maybe
> we should go ahead and commit this much anyway.
I am keen to see this relaxed. I agree that a separate effort is best.
David
| Attachment | Content-Type | Size |
|---|---|---|
| initstringinfo_changes_v4.patch | text/plain | 10.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2023-10-17 08:15:41 | Re: pg_stat_statements and "IN" conditions |
| Previous Message | Ashutosh Bapat | 2023-10-17 07:25:46 | serial and partitioned table |