Re: Refactor StringInfo usage in subscriptioncmds.c

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Mats Kindahl <mats(dot)kindahl(at)gmail(dot)com>
Cc: Álvaro Herrera <alvherre(at)kurilemu(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Refactor StringInfo usage in subscriptioncmds.c
Date: 2025-11-06 20:50:59
Message-ID: CAApHDvpqtYQeq7YkH9V-PNBJU-caBA4Arf8_zCmYuU1BQk8B3g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 7 Nov 2025 at 01:47, Mats Kindahl <mats(dot)kindahl(at)gmail(dot)com> wrote:
> > I agree with Amit that there doesn't seem to be a need to free
> > pubnames.data. We're already leaking publist, for instance. This is
> > okay since we only call these functions during DDL, which in general is
> > not sensitive to leaks.
>
> Seems reasonable. Here is an updated version that removes the pfree() calls.

Sounds like all are in favour. Pushed.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2025-11-06 21:54:41 Re: Built-in case-insensitive collation pg_unicode_ci
Previous Message Philip Alger 2025-11-06 20:19:29 Re: [PATCH] Add pretty formatting to pg_get_triggerdef