| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: A potential memory leak on Merge Join when Sort node is not below Materialize node |
| Date: | 2022-09-29 04:59:16 |
| Message-ID: | CAApHDvpozzg6hUmykziG4J9uU_g=OaPmFAGJMM=7qHf7ZQfpEw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 29 Sept 2022 at 14:32, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>
> On Wed, Sep 28, 2022 at 6:13 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > Master:
> > latency average = 313.197 ms
> >
> > Patched:
> > latency average = 304.335 ms
> >
> > So not a very impressive speedup there (about 3%)
>
> Worth a try, at least. Having a more consistent interface is valuable
> in itself too.
Just testing the datum sort in nodeSort.c with the same table as
before but using the query:
select b from t1 order by b offset 1000000;
Master:
latency average = 344.763 ms
Patched:
latency average = 268.374 ms
about 28% faster.
I'll take this to another thread and put it in the next CF
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2022-09-29 05:12:06 | Have nodeSort.c use datum sorts single-value byref types |
| Previous Message | Masahiko Sawada | 2022-09-29 04:52:47 | Re: [PATCH] Log details for client certificate failures |