Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options
Date: 2025-08-15 06:11:34
Message-ID: CAApHDvpoU3gZOxQcBPJ6v+=pqHhokN-+gvs4qCBWraU_kVnU-w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 15 Aug 2025 at 17:25, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Aug 15, 2025 at 04:48:10PM +1200, David Rowley wrote:
> > Yes, I'm about to push the HASH_STATISTICS one and backpatch to v17.
>
> Thanks.

Done

> > I think we should fix and backpatch the HASH_DEBUG one. We can have a
> > separate debate on removing it in master only. It's hard to imagine
> > anyone objecting to fixing it, so let's just do that for the time
> > being.
>
> Sounds good to me.

Also done. (I didn't use the proposed patch to fix that as the
proposed format wasn't correct. HIGH MASK was being changed to use %u
instead of %x, which I thought was unintended.)

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kirill Reshke 2025-08-15 06:16:32 Re: Skipping schema changes in publication
Previous Message Michael Paquier 2025-08-15 05:47:42 Re: Sequence Access Methods, round two