Re: Avoid lost result of recursion (src/backend/optimizer/util/inherit.c)

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Avoid lost result of recursion (src/backend/optimizer/util/inherit.c)
Date: 2022-12-22 09:21:51
Message-ID: CAApHDvpn5tRxx_AUvo9Fm4z37N=4MKs1FqC9n6xwLR=VFYWrSg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 22 Dec 2022 at 21:18, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> My best guess is that this function is intended to share the same code
> pattern as in adjust_appendrel_attrs_multilevel. The recursion is
> needed as 'rel' can be more than one inheritance level below the top
> parent. I think we can keep the recursion, as in other similar
> functions, as long as we make it right, as in attached patch.

I still think we should have a test to ensure this is actually
working. Do you want to write one?

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-12-22 09:23:34 Re: Force streaming every change in logical decoding
Previous Message Amit Kapila 2022-12-22 09:19:40 Re: Force streaming every change in logical decoding