Re: Refactor StringInfo usage in subscriptioncmds.c

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Mats Kindahl <mats(dot)kindahl(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Refactor StringInfo usage in subscriptioncmds.c
Date: 2025-11-06 11:54:13
Message-ID: CAApHDvpiprh4Geb+T=96OCNG31PSgrp7cCihy9R0ovOfttxkjw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 7 Nov 2025 at 00:38, Mats Kindahl <mats(dot)kindahl(at)gmail(dot)com> wrote:
> As discussed in [1] the functions check_publications_origin_tables() and
> check_publications_origin_sequences() are building error messages using
> dynamically allocated StringInfo instances only to avoid duplicating a
> call of ereport().

Looks better and more traditional to me, plus git diff --stat reports:

1 file changed, 28 insertions(+), 33 deletions(-)

It has my vote. I've included Vignesh and Amit to see if they're also
ok with it.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2025-11-06 12:05:59 Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue
Previous Message David Rowley 2025-11-06 11:46:56 Some efforts to get rid of "long" in our codebase