| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, David Rowley <drowley(at)postgresql(dot)org> |
| Subject: | Re: Bug in row_number() optimization |
| Date: | 2022-12-05 04:39:37 |
| Message-ID: | CAApHDvpZ=jSLt5woe1L39FhABjmoqGJyAnLfkodSSYZtBuM7KQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 1 Dec 2022 at 21:18, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>> + if (!func_strict(opexpr->opfuncid))
>> + return false;
>>
>> Should return true instead?
>
>
> Yeah, you're right. This should be a thinko.
Yeah, oops. That's wrong.
I've adjusted that in the attached.
I'm keen to move along and push the fix for this bug. If there are no
objections to the method in the attached and also adding the
restriction to limit the optimization to only working with strict
OpExprs, then I'm going to push this, likely about 24 hours from now.
David
| Attachment | Content-Type | Size |
|---|---|---|
| windowagg_fix_v3.patch | text/plain | 2.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-12-05 04:47:53 | Re: Optimize common expressions in projection evaluation |
| Previous Message | Pavel Stehule | 2022-12-05 04:36:44 | Re: Optimize common expressions in projection evaluation |