Re: [PATCH] Add tests for Bitmapset

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Greg Burd <greg(at)burd(dot)me>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Add tests for Bitmapset
Date: 2025-10-02 12:11:55
Message-ID: CAApHDvpYkS+=KPcCvYOF4Za9=a_D94Gd9x1oCzuz97He1_T0Pw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 2 Oct 2025 at 23:00, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> Doing post-commit review I didn't see any sharp edges, but found one more of
> these so will push this shortly:

Any chance you could also delete the "/* memory cleanup seems more
tricky than it's worth here */" line? That comment seemed relevant
when we were actually doing bms_free() in the functions. Now that
we're not, it's a bit out of place.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2025-10-02 12:15:50 Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
Previous Message Greg Burd 2025-10-02 12:09:55 Re: [PATCH] Add tests for Bitmapset