Re: Record a Bitmapset of non-pruned partitions

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Zhihong Yu <zyu(at)yugabyte(dot)com>
Cc: Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Record a Bitmapset of non-pruned partitions
Date: 2021-08-01 22:20:40
Message-ID: CAApHDvpN-fxu0JfxE=97zxqacJiFEDDF7_HwCzTJtJgAL5Vjbg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks for having a look at this.

On Mon, 2 Aug 2021 at 02:33, Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> Here we look for partitions which
> + * might be interleaved with other partitions and set the
> + * interleaved_parts field with the partition indexes of any partitions
> + * which may be interleaved with another partition.
>
> The above seems a little bit repetitive. It can be shortened to remove repetition.

I agree that the word "partition" is mentioned quite a few times. The
only one I can see that could be removed is the "partition indexes"
one. Likely the details about which bit we set can be left up to the
struct field comment in partbounds.h

I've adjusted this to become:

/*
* Calculate interleaved partitions. Here we look for partitions which
* might be interleaved with other partitions and set a bit in
* interleaved_parts for any partitions which may be interleaved with
* another partition.
*/

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2021-08-01 22:49:24 Re: Corrected documentation of data type for the logical replication message formats.
Previous Message Tomas Vondra 2021-08-01 22:01:25 Re: slab allocator performance issues