Re: Fix wrong filename in header comment of gin_tuple.h

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Richard Guo <guofenglinux(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, tomas(at)vondra(dot)me
Subject: Re: Fix wrong filename in header comment of gin_tuple.h
Date: 2025-09-22 20:02:40
Message-ID: CAApHDvpCOoOA-gkLUbtz9zgDFpGS7+qMAr3W-xXE2uzq6m03=A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 22 Sept 2025 at 14:46, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> diff --git a/src/backend/rewrite/rowsecurity.c b/src/backend/rewrite/rowsecurity.c

> - * rewrite/rowsecurity.c
> + * rowsecurity.c

> + *
> + * IDENTIFICATION
> + * src/backend/rewrite/rowsecurity.c

I don't what's incorrect with these as I'm not aware of the rule that
the IDENTIFICATION must exist or that the filename must be the
filename only without any of the path. Plenty of other files don't
have the identification text, so not sure why your script only picked
up on rowsecurity.c.

It maybe would make more sense if you posted the script, or
highlighted why rowsecurity.c is special out of all the files that
don't contain an "IDENTIFICATION".

Also, I'm not interested in making any large churn here for stylistic
reasons. I think that would end up as a huge patch for no measurable
gains.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-09-22 20:05:44 Re: [PATCH] Hex-coding optimizations using SVE on ARM.
Previous Message Tom Lane 2025-09-22 19:51:51 Re: RFC: extensible planner state