From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
---|---|
To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tv(at)fuzzy(dot)cz>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Use generation context to speed up tuplesorts |
Date: | 2021-08-08 12:38:27 |
Message-ID: | CAApHDvpBuuEp1KYdgE=AYOETUC3GF65i9p2z7FmaBN-aYKrFMw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, 4 Aug 2021 at 02:10, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
> I did run the same set of benchmarks as for Slab, measuring some usual
> allocation patterns. The results for i5-2500k machine are attached (for
> the xeon it's almost exactly the same behavior). While running those
> tests I realized the last patch is wrong and sets allocChunkLimit=1,
> which is bogus and causes significant regression. So here's an updated
> version of the patch series too.
I know you're not done with these yet, but FWIW, I was getting an
Assert failure with these patches on:
Assert(total_allocated == context->mem_allocated);
It seems to be because you've forgotten to ignore keeper blocks when
adjusting context->mem_allocated in GenerationReset()
David
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2021-08-08 12:51:21 | Re: Use generation context to speed up tuplesorts |
Previous Message | Tomas Vondra | 2021-08-08 12:38:00 | Re: Use generation context to speed up tuplesorts |