| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Differential code coverage between 16 and HEAD |
| Date: | 2024-04-15 22:26:57 |
| Message-ID: | CAApHDvpBphq_K18RcCk8_rxvk6WE8tPw0w1yvBjg9V_tWiotTA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 15 Apr 2024 at 10:33, Andres Freund <andres(at)anarazel(dot)de> wrote:
> - The new bump allocator has a fair amount of uncovered functionality:
> https://anarazel.de/postgres/cov/16-vs-HEAD-2024-04-14/src/backend/utils/mmgr/bump.c.gcov.html#L293
The attached adds a test to tuplesort to exercise BumpAllocLarge()
> https://anarazel.de/postgres/cov/16-vs-HEAD-2024-04-14/src/backend/utils/mmgr/bump.c.gcov.html#L613
I don't see a way to exercise those. They're meant to be "can't
happen" ERRORs. I could delete them and use BogusFree, BogusRealloc,
BogusGetChunkContext, BogusGetChunkSpace instead, but the ERROR
message would be misleading. I think it's best just to leave this.
David
| Attachment | Content-Type | Size |
|---|---|---|
| BumpAllocLarge_test.patch | text/plain | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-04-15 22:32:55 | Re: Removing GlobalVisTestNonRemovableHorizon |
| Previous Message | David G. Johnston | 2024-04-15 22:06:26 | Re: Things I don't like about \du's "Attributes" column |