Re: Allow parallel DISTINCT

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Zhihong Yu <zyu(at)yugabyte(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Allow parallel DISTINCT
Date: 2021-08-22 11:37:00
Message-ID: CAApHDvpAZywMtnC0Hy-z40WrQkA6Wou45jMWKBrW-1Lz8BHb5g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 18 Aug 2021 at 08:50, Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> The patch is good from my point of view.

Thanks for the review. I looked over the patch again and the only
thing I adjusted was the order of the RESETs in the regression tests.

I left the " if (distinct_rel->pathlist == NIL)" ERROR case check so
that the ERROR is raised before we call the FDW function and hook
function to add more paths. Part of me thinks it should probably go
afterwards, but I didn't want to change the behaviour there. The
other part of me thinks that if you can't do distinct by sorting or
hashing then there's not much hope for the hook to add any paths
either.

I've pushed this to master now.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-08-22 11:51:26 Re: Mark all GUC variable as PGDLLIMPORT
Previous Message Julien Rouhaud 2021-08-22 08:16:51 Re: Hook for extensible parsing.