| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com> |
| Cc: | Andrei Lepikhov <lepihov(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Lukas Fittl <lukas(at)fittl(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com> |
| Subject: | Re: Add estimated hit ratio to Memoize in EXPLAIN to explain cost adjustment |
| Date: | 2025-07-29 03:25:50 |
| Message-ID: | CAApHDvp2nD4zndtHRfk30LzAXHPm7jorDo0SVtqaQiLtppFjaA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 23 Jul 2025 at 23:08, Ilia Evdokimov
<ilya(dot)evdokimov(at)tantorlabs(dot)com> wrote:
> Given that, patch v11 still looks like the most appropriate version to me.
I spent a bit more time cleaning a few things up in this. With all the
complexity from the extra fields, I felt that a round of adjusting the
"double" types so they use the "Cardinality" typedef where appropriate
was in order. costsize.c isn't very good at doing that, but I didn't
see that as a reason to make the problem worse. The only other change
was in explain.c where I added a local "Memoize *" variable rather
than casting the "plan" variable to the subclass type in each usage.
I understand not everyone got what they wanted here, but I hope what's
been added is ok for the majority of people.
Thanks for working on this Ilia and Lukas.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-07-29 03:40:17 | Re: Broken ./configure checks for __cpuid() and __cpuidex() |
| Previous Message | jian he | 2025-07-29 03:13:53 | Re: implement CAST(expr AS type FORMAT 'template') |