| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: A tidyup of pathkeys.c |
| Date: | 2025-10-14 11:31:36 |
| Message-ID: | CAApHDvp0FCO-Qi+nQbbFwy4ZDf3yKpLsk7zjZ2+xcjy9Zt=PDA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 14 Oct 2025 at 21:05, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> FWIW, I complained about the stray check in has_useful_pathkeys() in
> [1] last week, but you were quicker than me in making the code change
> to remove it.
I missed that. I'm confident that line does nothing but waste cycles.
A quick look at how those pathkeys are set in standard_qp_callback()
should remove any uncertainty.
David
> [1] https://postgr.es/m/CAMbWs4_zW5QU=Zk32s17p8qWY+ga-3ZUTons+y+Wopguiopm4A@mail.gmail.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2025-10-14 11:37:46 | Re: Logical Replication of sequences |
| Previous Message | Álvaro Herrera | 2025-10-14 11:24:22 | Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement |